MLE-24733 - reversion, trying to get the tests to run properly #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the working version of the mlDeploy stuff to test-complete-app-mlDeploy
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the working mlDeploy configuration from the test-complete-app directory to a new test-complete-app-mlDeploy directory as part of test setup improvements. The main changes include:
- Moving mlDeploy configuration to a separate directory structure
- Restoring database configuration that was previously removed
- Updating test code to use the correct database client naming
Reviewed Changes
Copilot reviewed 11 out of 70 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test-complete/nodejs-optic-generate-views.js | Updated database client variable name from dbSchemasClient to dbModClient and changed target database |
| test-complete-app/gradle.properties | Removed database and REST server configuration properties |
| test-complete-app/build.gradle | Removed curl task definitions and mlDeploy finalization hooks |
| test-complete-app-mlDeploy/src/main/ml-config/servers/rest-api-server.json | Added REST API server configuration for SSL-enabled server |
| test-complete-app-mlDeploy/src/main/ml-config/security/certificate-templates/template-1.xml | Added SSL certificate template configuration |
| test-complete-app-mlDeploy/gradlew.bat | Added Gradle wrapper batch script for Windows |
| test-complete-app-mlDeploy/gradlew | Added Gradle wrapper shell script for Unix-based systems |
| test-complete-app-mlDeploy/gradle/wrapper/gradle-wrapper.properties | Added Gradle wrapper properties configuration |
| test-complete-app-mlDeploy/gradle.properties | Added database and REST server configuration properties |
| test-complete-app-mlDeploy/build.gradle | Added build configuration with certificate generation and curl tasks |
| .copyrightconfig | Updated to exclude the new test-complete-app-mlDeploy directory from copyright checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| var dbSchemasClient = marklogic.createDatabaseClient({ | ||
| database: 'Schemas', | ||
| var dbModClient = marklogic.createDatabaseClient({ | ||
| database: dbName + 'Modules', |
There was a problem hiding this comment.
The database name concatenation is missing proper string formatting. If dbName is a variable containing a database name, it should be followed by a hyphen or underscore separator (e.g., dbName + '-Modules'). Without a separator, this creates an incorrectly formatted database name.
Suggested change
| database: dbName + 'Modules', | |
| database: dbName + '-Modules', |
rjrudin
approved these changes
Oct 21, 2025
Contributor
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
Tests are passing for me locally, so I think we should merge this to fix the tests failing on develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted the working version of the mlDeploy stuff to test-complete-app-mlDeploy